[dv] Fix directed-test configuration and scheduling - #2497
Merged
hcallahan-lowrisc merged 3 commits intoOct 2, 2026
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document. By submitting this pull request comment, I am hereby confirming my acceptance of the terms of the CLA Document and my agreement to be legally bound by its terms. |
kulan-pal
force-pushed
the
dv/directed-test-sim-opts
branch
from
September 23, 2026 21:37
ea69428 to
0ae0e8a
Compare
This was referenced Sep 23, 2026
SamuelRiedel
approved these changes
Sep 29, 2026
SamuelRiedel
left a comment
SamuelRiedel
left a comment
Contributor
There was a problem hiding this comment.
Thanks @kulan-pal and sorry for the delay. This looks good to me. I just have one small nit.
Comment on lines
455
to
458
| def list_tests(dir): | ||
| testlist_str = os.popen('ls '+dir).read() | ||
| testlist = [] | ||
| for test in testlist_str.split('\n')[:-1]: | ||
| testlist.append(test) | ||
| print(testlist) | ||
| testlist = sorted(os.listdir(dir)) | ||
| print(testlist) | ||
| return testlist |
Contributor
There was a problem hiding this comment.
I think this function is never used anywhere.Would you mind just removing it instead of fixing it?
kulan-pal
force-pushed
the
dv/directed-test-sim-opts
branch
from
September 29, 2026 15:34
0ae0e8a to
e04906b
Compare
Contributor
Author
No worries, I understand how busy you are. Thanks for taking a look at my PRs. |
run_rtl.py passes a test's sim_opts to the simulator, but the schema for directed tests has no sim_opts field. pydantic drops unknown keys, so a directed test cannot set plusargs in its testlist entry. Add the field to DConfig as optional, so existing entries stay valid. On DConfig a config can set a default that a test still overrides. Signed-off-by: Kulan Palanichamy <kulan.palanichamy@opentitan.org>
The append that accepts a test sat inside the loop over its rtl_params, so a test with N parameters was scheduled N times. Every current test has one parameter, which hid it. Move the append to the loop's else clause, so it runs once after all parameters have matched. Signed-off-by: Kulan Palanichamy <kulan.palanichamy@opentitan.org>
gen_testlist.py listed the test directories with ls, whose order depends on the locale: sh-misaligned sorts before shamt under C and after it under en_US. The generated directed_testlist.yaml therefore depended on who ran the script. Use sorted(os.listdir()) and regenerate the file. No entry changes, only the order of a few vendored tests. Remove list_tests(), which nothing calls. Signed-off-by: Kulan Palanichamy <kulan.palanichamy@opentitan.org>
kulan-pal
force-pushed
the
dv/directed-test-sim-opts
branch
from
September 29, 2026 15:41
e04906b to
41a575d
Compare
hcallahan-lowrisc
approved these changes
Oct 2, 2026
hcallahan-lowrisc
left a comment
hcallahan-lowrisc
left a comment
Collaborator
There was a problem hiding this comment.
This is nice. Thanks a lot @kulan-pal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small fixes to the directed-test flow in
dv/uvm/core_ibex. None of them changes which tests run today.They are needed by directed tests that set their own plusargs (#2498, #2500).
sim_optswas dropped.run_rtl.pypassessim_optsto the simulator, but the directed-test schema hadno such field, so pydantic threw it away. It is now an optional field of
DConfig.rtl_paramsran N times. The accept infilter_tests_by_configsat inside the loop over theparameters. It now runs once, in the loop's
else:. Every current test has one parameter, so this never showed.directed_testlist.yamldepended on the locale.gen_testlist.pylisted directories withls; it nowuses
sorted(os.listdir()). The regenerated file has the same 944 entries, with a few vendored tests reordered.Checked on e1a6be2: the testlist regenerates byte-identical, and
zcmp_reserved_testfrom #2498 (twortl_paramsand asim_opts) is scheduled once with its plusarg on the simulator command line.The
directed_testsbranch adds the same field toDTest. Whichever lands second can drop its copy.AI disclosure (CLA §9): written with help from Claude Code and reviewed with OpenAI Codex; I have reviewed and understood every change and take full responsibility for it.